Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.4.1 #517

Merged
merged 52 commits into from
Nov 9, 2023
Merged

Release 6.4.1 #517

merged 52 commits into from
Nov 9, 2023

Conversation

AndrewPlayer3
Copy link
Contributor

No description provided.

dependabot bot and others added 30 commits October 3, 2023 15:24
@dependabot
Bump aws-actions/amazon-ecr-login from 1 to 2
0c3dd98 
Bumps [aws-actions/amazon-ecr-login](https://github.com/aws-actions/amazon-ecr-login) from 1 to 2.
- [Release notes](https://github.com/aws-actions/amazon-ecr-login/releases)
- [Changelog](https://github.com/aws-actions/amazon-ecr-login/blob/main/CHANGELOG.md)
- [Commits](aws-actions/amazon-ecr-login@v1...v2)

---
updated-dependencies:
- dependency-name: aws-actions/amazon-ecr-login
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jtherrmann
Merge pull request #495 from ASFHyP3/dependabot/github_actions/aws-ac…
fccf005 
…tions/amazon-ecr-login-2

Bump aws-actions/amazon-ecr-login from 1 to 2
@AndrewPlayer3
reproject into the correct coordinate system
4415430
@cirrusasf
need libspatialindex-dev and rtree library to make the geopandas.clip…
483a534 
… work, modify the create_water_mask function to corrrect wrong mask shapefile and make the gdal.rasteize work
@cirrusasf
modify the code style
5001bc2
@AndrewPlayer3
Merge pull request #508 from ASFHyP3/water_mask_error_jz
b474ccb 
need libspatialindex-dev and rtree library to make the geopandas.clip…
@AndrewPlayer3
added hyp3-isce2's water masking improvements
83b80bd
@cirrusasf
read parquet file, add needed libraries in the environmenmt file
ce2c168
@AndrewPlayer3
added newline
a0029e5
@AndrewPlayer3
updated changelog
0baea5a
@AndrewPlayer3
Merge pull request #509 from ASFHyP3/water-mask-error
e0affe1 
Fixed Errors in Water Masking Over Europe
@AndrewPlayer3
add s3fs to requirements
1dace92
@AndrewPlayer3
add pyarrow to requirements
d4b74c7
@AndrewPlayer3
Merge pull request #510 from ASFHyP3/water-mask-error
8805d4a 
add s3fs to requirements
@cirrusasf
add shapely>=2.0 in the setup.py and environment.yml
4d5427d
@cirrusasf
downgrade shapely to v 1.8.0, in order to keep its compibible to GAMM…
7bd14d6 
…A version
@cirrusasf
remove import shapely statement in water_mask.py
ca36460
@cirrusasf @AndrewPlayer3
Update hyp3_gamma/water_mask.py
0760fc0 
Co-authored-by: Andrew Player <[email protected]>
@cirrusasf
Merge pull request #511 from ASFHyP3/water_mask_error_jz_t2
fc3f59d 
add shapely>=2.0 in the setup.py and environment.yml
@cirrusasf
need to add libspatialindex-dev and rtree for making the geopandas.cl…
7273723 
…ip() work
@cirrusasf
modify environment.yml to install rtree and pyarrow with conda
54dad01
@jhkennedy
Update environment.yml
27dd145
@cirrusasf
Merge pull request #512 from ASFHyP3/water_mask_error_jz_t2
b347024 
need to add libspatialindex-dev and rtree for making the geopandas.cl…
@cirrusasf
back to the previous way of reasding the mask with geopandas.read_fil…
fcbf490 
…e, add clip with extent
@cirrusasf
keep rtree library to make geopandas.clip works
7afee62
@cirrusasf
add geopandasa.clip() to clip mask to the extent
8f65479
@cirrusasf
solve the partition issue when read the parquet file and filter forma…
9fdc17d 
…t, solve the antimeridian issue
@cirrusasf
modify code style
af06197
@AndrewPlayer3
refactoring
9faeb97
@AndrewPlayer3
refactoring
4bb89c7
cirrusasf and others added 15 commits November 6, 2023 10:33
@cirrusasf
Merge pull request #514 from ASFHyP3/water_mask_error_jz_t3
2ed0654 
back to the previous way of reasding the mask with geopandas.read_fil…
@AndrewPlayer3
fixed errors in water masking
171b462
@AndrewPlayer3
Merge pull request #515 from ASFHyP3/water-mask-fixes
3598496 
Fix Errors in Water Masking
@cirrusasf
do not split the antimeridian extent, but convert it into UTM, then d…
3a7b0f3 
…o read_file and clip with the envelope of extent
@cirrusasf
code style
cc8fe60
@cirrusasf
code style
80dbe28
@cirrusasf
refactor code
3780588
@cirrusasf
code style
812485d
@cirrusasf
remove split_antimeridian function and its test function
eb3d747
@cirrusasf @AndrewPlayer3
Update hyp3_gamma/water_mask.py
a796cc1 
Co-authored-by: Andrew Player <[email protected]>
@cirrusasf
use pyogrio engine to do geopandas.read_file
76e35e2
@cirrusasf
add pyogrio library in the environment.yml and setup.py
c493ed7
@cirrusasf
code style
1210f3d
@cirrusasf
decide use geopandas.read_file with mask equal to envelope in the inp…
d592504 
…ut reference file projection
@cirrusasf
Merge pull request #516 from ASFHyP3/water_mask_antimeridian
5a8514a 
do not split the antimeridian extent, but convert it into UTM, then d…
@AndrewPlayer3 AndrewPlayer3 added the patch Bump the patch version number of this project label Nov 8, 2023
@AndrewPlayer3 AndrewPlayer3 requested a review from a team as a code owner November 8, 2023 22:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited by AndrewPlayer3
Loading

Developer checklist

  • Indicated the level of changes to this package by affixing one of these labels:
    • major -- Major changes to the API that may break current workflows
    • minor -- Minor changes to the API that do not break current workflows
    • patch -- Patches and bugfixes for the current version that do not break current workflows
    • bumpless -- Changes to documentation, CI/CD pipelines, etc. that don't affect the software's version
  • (If applicable) Updated the dependencies and indicated any downstream changes that are required
  • Added/updated documentation for these changes
  • Added/updated tests for these changes

Reviewer checklist

  • Have all dependencies been updated?
  • Is the level of changes labeled appropriately?
  • Are all the changes described appropriately in CHANGELOG.md?
  • Has the documentation been adequately updated?
  • Are the tests adequate?

cirrusasf
cirrusasf reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@cirrusasf cirrusasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest for CHANGELOG.md "Use envelope of input file in its projection to create water mask to overcome antimeridian and significantly incorrect over some regions in Europe" . please re wording this, but I would like to include actual change for this release

@AndrewPlayer3 AndrewPlayer3 merged commit a854b27 into main Nov 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirrusasf cirrusasf cirrusasf approved these changes

Assignees
No one assigned
Labels
patch Bump the patch version number of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewPlayer3 @cirrusasf @jtherrmann @jhkennedy